Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default service config not honored if initial name resolution fails #11040

Closed
temawi opened this issue Mar 26, 2024 · 8 comments · Fixed by #11577
Closed

Default service config not honored if initial name resolution fails #11040

temawi opened this issue Mar 26, 2024 · 8 comments · Fixed by #11577
Labels
Milestone

Comments

@temawi
Copy link
Contributor

temawi commented Mar 26, 2024

If the name resolution fails we are supposed to rely on the default service config since there is no way to get one via name resolution. This currently only happens if there has been at least one successful name resolution call. If the first name resolution fails, ManagedChannelImpl does not apply the service config.

@sergiitk
Copy link
Member

sergiitk commented Mar 27, 2024

Came out of #11018. May be full or partial solution for it.

@vinodhabib
Copy link
Contributor

@kannanjgithub added the fix and writing the UT for the fix in progress

@vinodhabib
Copy link
Contributor

@kannanjgithub PR raised for the Review, Request you to have a look once.

PR Link - #11368

@vinodhabib
Copy link
Contributor

Completed Fix along with UT cases and PR got Approved.

@vinodhabib
Copy link
Contributor

Got some more Review points recently from @ejona86 @kannanjgithub working on them.

@vinodhabib
Copy link
Contributor

vinodhabib commented Aug 29, 2024

Fixed the recent review points and PR is ready for re-review.

@vinodhabib
Copy link
Contributor

Fixed the Recent Review point and PR is Ready for Re-review

@ejona86
Copy link
Member

ejona86 commented Sep 3, 2024

@vinodhabib, please don't do those PR updates here. Do them on the PR.

@ejona86 ejona86 modified the milestones: Next, 1.68 Oct 1, 2024
kannanjgithub added a commit to kannanjgithub/grpc-java that referenced this issue Oct 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants