-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default service config not honored if initial name resolution fails #11040
Comments
Came out of #11018. May be full or partial solution for it. |
@kannanjgithub added the fix and writing the UT for the fix in progress |
@kannanjgithub PR raised for the Review, Request you to have a look once. PR Link - #11368 |
Completed Fix along with UT cases and PR got Approved. |
Got some more Review points recently from @ejona86 @kannanjgithub working on them. |
Fixed the recent review points and PR is ready for re-review. |
Fixed the Recent Review point and PR is Ready for Re-review |
@vinodhabib, please don't do those PR updates here. Do them on the PR. |
If the name resolution fails we are supposed to rely on the default service config since there is no way to get one via name resolution. This currently only happens if there has been at least one successful name resolution call. If the first name resolution fails,
ManagedChannelImpl
does not apply the service config.The text was updated successfully, but these errors were encountered: