chore: setup golangci-lint #7994
Open
+1,252
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7994 +/- ##
==========================================
+ Coverage 82.00% 82.24% +0.24%
==========================================
Files 381 381
Lines 38539 38539
==========================================
+ Hits 31602 31698 +96
+ Misses 5612 5540 -72
+ Partials 1325 1301 -24 |
29de56b to
4d078da
Compare
79a2880 to
1791d04
Compare
|
/cc @arjan-bal |
5f17098 to
822bbd2
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
822bbd2 to
37d2f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #7974 (comment)
Using golangci-lint will provide a common config file for all already used linters.
With this config comments can be provided.
Until now revive was only applied in the main module and not in submodules.
With one tool, this behavior will be avoided.
It will also provide a simpler way to provide new linters
RELEASE NOTES: None