-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats/opentelemetry: Cleanup OpenTelemetry API's before stabilization #7874
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7874 +/- ##
==========================================
+ Coverage 81.94% 82.12% +0.17%
==========================================
Files 377 377
Lines 38120 38112 -8
==========================================
+ Hits 31239 31298 +59
+ Misses 5572 5520 -52
+ Partials 1309 1294 -15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor wording suggestions. Please check out the edits-as-commits and suggested changes.
stats/opentelemetry/opentelemetry.go
Outdated
// cardinality and could cause severe memory or performance problems. On | ||
// Client Side, to record the method name along with metric instead of | ||
// bucketing into "other pass a grpc.StaticMethodCallOption as a call option | ||
// into Invoke or NewStream. | ||
// | ||
// This only applies for server side metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// cardinality and could cause severe memory or performance problems. On | |
// Client Side, to record the method name along with metric instead of | |
// bucketing into "other pass a grpc.StaticMethodCallOption as a call option | |
// into Invoke or NewStream. | |
// | |
// This only applies for server side metrics. | |
// cardinality and could cause severe memory or performance problems. | |
// | |
// This only applies for server-side metrics. For clients, to record | |
// the method name in the attributes, pass grpc.StaticMethodCallOption | |
// to Invoke or NewStream. Note that when using protobuf generated | |
// clients, this CallOption is included automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
stats/opentelemetry/opentelemetry.go
Outdated
// OptionalLabels specifies a list of optional labels that will be included | ||
// on any metrics that have corresponding optional labels configured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// OptionalLabels specifies a list of optional labels that will be included | |
// on any metrics that have corresponding optional labels configured. | |
// OptionalLabels specifies a list of optional labels to enable on any | |
// metrics that support them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I couldn't figure out a way to tersely convey it's just the subset that are "supported" that are enabled. (i.e. it's not always the full set added optionally, but the ones that are actually also configured. Changed to your suggestion.
93e5272
to
7f99944
Compare
This PR cleans up some OpenTelemetry API's before stabilization.
RELEASE NOTES: