test/xds: remove redundant server when using stubserver in tests #7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7846 +/- ##
==========================================
- Coverage 81.84% 81.77% -0.07%
==========================================
Files 374 375 +1
Lines 37993 37986 -7
==========================================
- Hits 31096 31064 -32
- Misses 5598 5612 +14
- Partials 1299 1310 +11
|
|
@janardhanvissa are you improving your previous changes? If yes, could you tag the previous PR and mention what was missed which you are addressing here? |
Yes, In the PR #7708 missed to pass sopts to stubserver and moving listener at the stub initialization are addressed in this PR. |
purnesh42H
reviewed
Nov 19, 2024
3d9fd67 to
4f45041
Compare
purnesh42H
reviewed
Nov 20, 2024
purnesh42H
reviewed
Nov 22, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Nov 27, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Dec 4, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses: #7291
RELEASE NOTES: None