Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials: remove the context timeout to fix token request failure with non-GCE ADC #7845

Merged
merged 3 commits into from
Nov 19, 2024

fix vet

0381aae
Select commit
Loading
Failed to load commit list.
Merged

credentials: remove the context timeout to fix token request failure with non-GCE ADC #7845

fix vet
0381aae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

81.74% (-0.11%) compared to 66385b2

View this Pull Request on Codecov

81.74% (-0.11%) compared to 66385b2

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.74%. Comparing base (66385b2) to head (0381aae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7845      +/-   ##
==========================================
- Coverage   81.84%   81.74%   -0.11%     
==========================================
  Files         374      374              
  Lines       37993    37994       +1     
==========================================
- Hits        31096    31057      -39     
- Misses       5598     5622      +24     
- Partials     1299     1315      +16     
Files with missing lines Coverage Δ
credentials/google/google.go 77.33% <100.00%> (+0.30%) ⬆️

... and 25 files with indirect coverage changes