grpc: Remove health check func dial option used for testing #7820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7820 +/- ##
==========================================
- Coverage 82.00% 81.86% -0.15%
==========================================
Files 373 373
Lines 37735 37841 +106
==========================================
+ Hits 30945 30977 +32
- Misses 5512 5565 +53
- Partials 1278 1299 +21
|
easwars
approved these changes
Nov 7, 2024
clientconn.go
Outdated
| @@ -1477,7 +1477,7 @@ func (ac *addrConn) startHealthCheck(ctx context.Context) { | |||
| } | |||
| // Start the health checking stream. | |||
| go func() { | |||
| err := ac.cc.dopts.healthCheckFunc(ctx, newStream, setConnectivityState, healthCheckConfig.ServiceName) | |||
| err := internal.HealthCheckFunc(ctx, newStream, setConnectivityState, healthCheckConfig.ServiceName) | |||
There was a problem hiding this comment.
Could this use the local variable healthCheckFunc instead?
There was a problem hiding this comment.
Yes, changed to use the local var.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the private
withHealthCheckFuncdialoption which is used only in the health check tests. The tests are able to replace theHealthCheckFuncvar defined in theinternalpackage directly and restore it as part of the test cleanup.Background
While working on the health producer changes which are part of generic health checks, I needed to pass the dial option to the health producer while registering a health listener just to make the existing tests pass. The HealthCheckFunc would become a part of the producer's public API, even though it is required only for testing. I changed the tests to work without the dial option.
RELEASE NOTES: N/A