Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdsclient: send Node proto only on first discovery request on ADS stream #6078

Merged
merged 2 commits into from
Mar 3, 2023
Merged

xdsclient: send Node proto only on first discovery request on ADS stream #6078

merged 2 commits into from
Mar 3, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Mar 3, 2023

This PR adds functionality to the xdsclient transport to send the node proto only on the first request on the stream. If the stream breaks, the node proto will be sent on the first request of subsequent streams as well.

Other changes in this PR (mostly testing related)

  • New tests to verify behavior added in this PR.
  • Move the testResourceWatcher type from authority_test.go into xds/internal/testutils package, and export it.
  • Update authority_test.go to use the new TestResourceWatcher type exported above.
  • Enable the fakeserver.Server to be started with a net.Listener provided by the test.

Fixes #5668.

RELEASE NOTES:

  • xdsclient: send Node proto only on first discovery request on ADS stream

@easwars easwars requested a review from arvindbr8 March 3, 2023 01:45
@easwars easwars added the Type: Feature New features or improvements in behavior label Mar 3, 2023
@easwars easwars added this to the 1.54 Release milestone Mar 3, 2023
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Mar 3, 2023
@easwars easwars assigned arvindbr8 and unassigned easwars Mar 3, 2023
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 Mar 3, 2023
@easwars easwars merged commit b9e6d59 into grpc:master Mar 3, 2023
@easwars easwars deleted the xdsclient_node_on_first_message_only branch March 23, 2023 18:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@easwars easwars

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.54 Release
Development

Successfully merging this pull request may close these issues.

xds: implement set_node_on_first_message_only equivilent
2 participants
@easwars @arvindbr8