xds: fix panic involving double close of channel in xDS transport #5959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Jan 23, 2023
| <-t.lrsRunnerDoneCh | ||
| t.lrsRunnerDoneCh = nil |
There was a problem hiding this comment.
Technically this is unnecessary, right? Maybe remove it?
There was a problem hiding this comment.
Yes, technically unnecessary. Just paranoia I guess.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code was using a single channel in the xDS
Transporttype to ensure that the LRS goroutine exited when closing LRS streams. This was leading to a double close of the associated channel when multiple streams were started and closed. This PR changes the logic such that a new channel is created every time a new stream is created. Since we know that there can be only one active stream per transport, this approach works perfectly.Fixes internal P1 issue.
This also needs to be backported to
v1.52.x.RELEASE NOTES: