Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alts: copy more credentials fields in Clone() #2119

Merged
merged 2 commits into from
Jun 1, 2018
Merged

alts: copy more credentials fields in Clone() #2119

merged 2 commits into from
Jun 1, 2018

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Jun 1, 2018

No description provided.

@menghanl menghanl requested a review from cesarghali June 1, 2018 21:49
@cesarghali
Copy link
Contributor

Thanks for the PR Menghan. Can you please also copy the other fields, accounts and side?

@menghanl menghanl merged commit 130c87f into grpc:master Jun 1, 2018
@menghanl menghanl deleted the alts_clone_hsaddress branch June 1, 2018 22:36
@menghanl menghanl changed the title alts: copy handshake address in Clone() alts: copy more credentials fields in Clone() Jun 1, 2018
@menghanl menghanl added this to the 1.13 Release milestone Jun 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cesarghali cesarghali cesarghali approved these changes

Assignees

@cesarghali cesarghali

Labels
Type: Bug
Projects
None yet
Milestone
1.13 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @cesarghali