codes: fix: marshal/unmarshal a Code to JSON fails #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marshalling a Code to JSON and unmarshalling it failed with an "invalid code" error message. Code is of type uint32. It has no custom MarshalJson() implemented therefore it is marshalled into an JSON integer value. The UnmarshalJSON() function expected that the marshalled Code is a String type, unmarshalling failed. Check in UnmarshalJSON() if the value is an uint32 in the range of the defined Code values. If it is, unmarshal it. This commit also adds an Marshal/Unmarshal testcase.
florinutz
approved these changes
Jun 1, 2018
menghanl
approved these changes
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshalling a Code to JSON and unmarshalling it failed with an
"invalid code" error message.
Code is of type uint32. It has no custom MarshalJson() implemented
therefore it is marshalled into an JSON integer value.
The UnmarshalJSON() function expected that the marshalled Code is a
String type, unmarshalling failed.
Check in UnmarshalJSON() if the value is an uint32 in the range of the
defined Code values. If it is, unmarshal it.
This commit also adds an Marshal/Unmarshal testcase.