Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error for non-default DNS authority. #2067

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Throw an error for non-default DNS authority. #2067

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb47ed8
Throw an error for non-default DNS authority.
jsha May 11, 2018
a2ddad9
Review feedback.
jsha Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions resolver/dns/dns_resolver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ type dnsBuilder struct {

// Build creates and starts a DNS resolver that watches the name resolution of the target.
func (b *dnsBuilder) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOption) (resolver.Resolver, error) {
if target.Authority != "" {
return nil, fmt.Errorf("non-default DNS resolver %q not supported", target.Authority)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the error message to "Default DNS resolver does not support custom DNS server"? Thanks!

}
host, port, err := parseTarget(target.Endpoint)
if err != nil {
return nil, err
Expand Down