Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventSource and activity tags to server #341

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Add EventSource and activity tags to server #341

merged 3 commits into from
Jul 15, 2019

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jun 19, 2019 •
edited
Loading

Addresses #318, #283

Built on top of #334

Changes in c986480

@JamesNK JamesNK requested review from davidfowl and JunTaoLuo June 19, 2019 10:20
@JamesNK JamesNK force-pushed the jamesnk/eventsource branch 2 times, most recently from d4604f4 to be0f551 Compare June 21, 2019 07:46
@JamesNK JamesNK changed the title Add EventSource to server Add EventSource and activity tags to server Jun 22, 2019
JunTaoLuo
JunTaoLuo approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would prefer a new gRPC activity but we can address that separately if you want to get this merged.

examples/Server/Startup.cs Show resolved Hide resolved
src/Grpc.AspNetCore.Server/Internal/GrpcEventSource.cs Show resolved Hide resolved
src/Grpc.AspNetCore.Server/Internal/HttpContextServerCallContext.cs Outdated Show resolved Hide resolved
jtattermusch
jtattermusch approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JamesNK JamesNK force-pushed the jamesnk/eventsource branch 2 times, most recently from 8d43821 to 984fde5 Compare June 28, 2019 08:51
@JamesNK
Copy link
Member Author

JamesNK commented Jun 28, 2019

@lmolkova @davidfowl All feedback applied.

@JamesNK JamesNK mentioned this pull request Jun 28, 2019
Merged
@JamesNK JamesNK force-pushed the jamesnk/eventsource branch from 63d31cf to ffe1119 Compare July 15, 2019 06:48
@JamesNK JamesNK merged commit cd67606 into grpc:master Jul 15, 2019
@alanwest alanwest mentioned this pull request Jul 28, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova left review comments

@davidfowl davidfowl davidfowl left review comments

@jtattermusch jtattermusch jtattermusch approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JamesNK @davidfowl @JunTaoLuo @lmolkova @jtattermusch