protoc-gen-swagger: correctly type struct.proto types #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achew22
approved these changes
Aug 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 40 40
Lines 4028 4028
=======================================
Hits 2153 2153
Misses 1676 1676
Partials 199 199
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989
The NullValue, Value and List types are not accurately describable, but this is better than it was.
I've tested all 4 of these definitions with https://editor.swagger.io/ so I'm confident it produces correct output.