Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested oneof test #2323

Merged

Conversation

momom-i
Copy link
Contributor

@momom-i momom-i commented Sep 6, 2021

References to other Issues or PRs

#753

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

When the issue was created, grpc_gateway version seemed v1 and the problem mentioned in it is fixed in v2.
But I wrote test that checked nested oneof value case.

Other comments

@google-cla google-cla bot added the cla: yes label Sep 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2323 (ca0d224) into master (77176e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   59.64%   59.64%           
=======================================
  Files          35       35           
  Lines        4500     4500           
=======================================
  Hits         2684     2684           
  Misses       1525     1525           
  Partials      291      291           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe2d42...ca0d224. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thanks a lot for this test!

@johanbrandhorst johanbrandhorst merged commit 8478702 into grpc-ecosystem:master Sep 7, 2021
@momom-i momom-i deleted the add-nested-oneof-test branch September 8, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants