Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate log messages resulting from requests being sent over a Unix Domain Socket #1543

Conversation

janzantinge
Copy link
Contributor

Fixes #1538

Removed the "invalid remote addr" log that's printed when a http request's remote address is not an IP:port while setting the X-Forwarded-For header. This issue arose specifically when requests arrived via an abstract Unix Domain Socket.

…est's remote address is not an IP:port while setting the X-Forwarded-For header
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janzantinge
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst johanbrandhorst merged commit 42903b1 into grpc-ecosystem:master Jul 22, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry-pick this fix against v2?

janzantinge added a commit to janzantinge/grpc-gateway that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log spam during attempt to append remote address to the XFF header when the transport is a unix domain socket
3 participants