Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken season of docs links (#1497) #1498

Merged
merged 1 commit into from
Jul 3, 2020
Merged

docs: fix broken season of docs links (#1497) #1498

merged 1 commit into from
Jul 3, 2020

Conversation

dufcrule
Copy link
Contributor

@dufcrule dufcrule commented Jul 3, 2020

References #1497

@dufcrule dufcrule mentioned this pull request Jul 3, 2020
Merged
@johanbrandhorst
Copy link
Collaborator

Just a note about links in this document; obviously this is on the v2 branch but we're linking to the master version of the issue template, etc. This is intentional, I think what we want to do when we do finally cut v2 is to make a large merge into master, so that v2 releases can be made from the master branch, and these links will then be correct.

@johanbrandhorst johanbrandhorst merged commit fcec199 into grpc-ecosystem:v2 Jul 3, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dufcrule @johanbrandhorst @googlebot