Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docs about controlling http response status codes #1391

Merged
merged 2 commits into from
May 25, 2020
Merged

Adding docs about controlling http response status codes #1391

merged 2 commits into from
May 25, 2020

Conversation

zhughes3
Copy link
Contributor

References to other Issues or PRs

Adding notes to documentation after repeated discussion in #517 (comment)

Brief description of what is fixed or changed

Added documentation about controlling http response status codes.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zhughes3
Copy link
Contributor Author

@googlebot I signed it!

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #1391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1391   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          42       42           
  Lines        4375     4375           
=======================================
  Hits         2369     2369           
  Misses       1750     1750           
  Partials      256      256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f308a6...321a5be. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks great! Just a few nitpicky details:

  • Could you unindent the code blocks to make it consistent with the rest of the file please?
  • Looks like you've got too many tabs in the last snippet.

@johanbrandhorst
Copy link
Collaborator

@googlebot I signed it!

Try this without a quote

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst johanbrandhorst merged commit 3217094 into grpc-ecosystem:master May 25, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry pick this against v2?

@zhughes3
Copy link
Contributor Author

@johanbrandhorst Of course! I am trying to cherry pick it into the v2 branch. If you can be patient, my git-fu is still amateur at best.

@zhughes3 zhughes3 deleted the patch-1 branch May 25, 2020 18:44
zhughes3 added a commit to zhughes3/grpc-gateway-1 that referenced this pull request May 26, 2020
…tem#1391)

* Adding docs about controlling http response status codes

* PR changes based on review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants