-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docs about controlling http response status codes #1391
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
=======================================
Coverage 54.14% 54.14%
=======================================
Files 42 42
Lines 4375 4375
=======================================
Hits 2369 2369
Misses 1750 1750
Partials 256 256 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks great! Just a few nitpicky details:
- Could you unindent the code blocks to make it consistent with the rest of the file please?
- Looks like you've got too many tabs in the last snippet.
Try this without a quote |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for your contribution! Could you please cherry pick this against v2? |
@johanbrandhorst Of course! I am trying to cherry pick it into the v2 branch. If you can be patient, my git-fu is still amateur at best. |
…tem#1391) * Adding docs about controlling http response status codes * PR changes based on review
References to other Issues or PRs
Adding notes to documentation after repeated discussion in #517 (comment)
Brief description of what is fixed or changed
Added documentation about controlling http response status codes.