remove deprecated usage of github.com/golang/protobuf/protoc-gen-go/generator #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d0ca75 to
20d4eb5
Compare
johanbrandhorst
requested changes
Apr 18, 2020
|
Hmmm so now it's failing for a reason I have no idea about. |
|
Gorelease is failing because you're not up to date with master. Please rebase your branch. The bazel failure looks like a flaky test, unfortunately, I reran it. |
2f46ff0 to
aabefa2
Compare
|
There. Fixed :) |
johanbrandhorst
approved these changes
Apr 22, 2020
|
Thanks for your contribution! Could you please cherry pick this against the v2 branch as well? |
pull bot
pushed a commit
to BuildingRobotics/grpc-gateway
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/golang/protobuf/protoc-gen-go/generator package is now deprecated and causes warnings when used. This causes this plugin to fail when used with some protoc related tools (like prototool) as they expect all plugins to not write to stdout/stderr except for returning the generation results.
We only use the "CamelCase" function from that package so I just copied it into the template.go