genswagger: don't emit default response if there's no Error definition #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger: do not create default response definitions if we can't find Error/StreamError in Registry, even if `DisableDefaultErrors()` is false. Logs are still emitted if default errors are enabled, but error definition was not found. grep: `.grpc.gateway.runtime.Error`, `.grpc.gateway.runtime.StreamError` Closes grpc-ecosystem#1162
utrack
commented
Mar 10, 2020
johanbrandhorst
requested changes
Mar 10, 2020
now tests require properly loaded registry to lookup swagger names and stuff. :)
|
@johanbrandhorst the code looks a bit messier now because of more if branches; however, I don't want to do refactoring in the same PR so the changes would be as small as possible. This calls for a separate PR :) |
johanbrandhorst
approved these changes
Mar 11, 2020
|
Would appreciate a further refactor in a separate PR if you have the time :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger: do not create default response definitions if we can't find Error/StreamError in Registry, even if
DisableDefaultErrors()is false.Logs are still emitted if default errors are enabled, but error definition was not found.
grep:
.grpc.gateway.runtime.Error,.grpc.gateway.runtime.StreamErrorCloses #1162