Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1125: JSON-prefix nested-field params. #1126

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Fix #1125: JSON-prefix nested-field params. #1126

merged 2 commits into from
Feb 2, 2020

Conversation

jgiles
Copy link
Contributor

@jgiles jgiles commented Feb 2, 2020

No description provided.

@jgiles jgiles mentioned this pull request Feb 2, 2020
Closed
@codecov-io
Copy link

Codecov Report

Merging #1126 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   53.88%   53.94%   +0.05%     
==========================================
  Files          42       42              
  Lines        4166     4171       +5     
==========================================
+ Hits         2245     2250       +5     
  Misses       1677     1677              
  Partials      244      244
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/template.go 57.39% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16fcd4...859751c. Read the comment docs.

johanbrandhorst
johanbrandhorst approved these changes Feb 2, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for the bug fix!

@johanbrandhorst johanbrandhorst merged commit f0d0de4 into grpc-ecosystem:master Feb 2, 2020
@jgiles jgiles deleted the nested-query-json branch February 2, 2020 16:18
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
@jgiles
Fix grpc-ecosystem#1125: JSON-prefix nested-field params. (grpc-ecosy…
0ef14fe 
…stem#1126)

* Fix grpc-ecosystem#1125: JSON-prefix nested-field params.

* Add test case.
pull bot pushed a commit to BuildingRobotics/grpc-gateway that referenced this pull request Apr 29, 2020
@jgiles @pull
Fix grpc-ecosystem#1125: JSON-prefix nested-field params. (grpc-ecosy…
c4ef054 
…stem#1126)

* Fix grpc-ecosystem#1125: JSON-prefix nested-field params.

* Add test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgiles @codecov-io @johanbrandhorst @googlebot