-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added additional info for custom http headers #1035
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 53.62% 53.62%
=======================================
Files 40 40
Lines 4052 4052
=======================================
Hits 2173 2173
Misses 1674 1674
Partials 205 205 Continue to review full report at Codecov.
|
@cemenson welcome to the party! 🎉 🎈 🎉 This is a great first PR on a project and great first contribution to the open source world. Thank you so much for taking the time to fix something that didn't look right. This is how open source gets better. I look forward to your next PR, and if there is anything I can do to have it be one that enhances this project, just let me know. Thanks again! |
Thanks @achew22! Glad to help! |
Sorry, such a noob. Am I supposed to close this PR? |
No, but I appreciate your trying to help. On my side there is a "merge" button which I needed to hit. However, I wanted to make sure the tests passed before submitting. Sorry I forgot about this tab and just got back to it. It should be merged now in the |
* added additional info for custom http headers
Hi all,
First pull request (ever). Love grpc-gateway, keep up the great work!
I've made a couple of tiny changes to the "Customizing Your Gateway" docs page:
HeaderMatcherFunc
example, showing a couple of ways of returning the custom header key.gRPC.SendHeader()
as well as a small pointer to the gRPC metadata docs for more info.That's it! It would have help me a little if they were there when I was setting this up for the first time, so I'm hoping this will help others.
Thanks!