Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added additional info for custom http headers #1035

Merged
merged 3 commits into from
Sep 9, 2019
Merged

added additional info for custom http headers #1035

merged 3 commits into from
Sep 9, 2019

Conversation

cemenson
Copy link
Contributor

@cemenson cemenson commented Sep 9, 2019

Hi all,

First pull request (ever). Love grpc-gateway, keep up the great work!

I've made a couple of tiny changes to the "Customizing Your Gateway" docs page:

  1. Added a HeaderMatcherFunc example, showing a couple of ways of returning the custom header key.
  2. Added a small example of sending a response header from the server using gRPC.SendHeader() as well as a small pointer to the gRPC metadata docs for more info.

That's it! It would have help me a little if they were there when I was setting this up for the first time, so I'm hoping this will help others.

Thanks!

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #1035 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   53.62%   53.62%           
=======================================
  Files          40       40           
  Lines        4052     4052           
=======================================
  Hits         2173     2173           
  Misses       1674     1674           
  Partials      205      205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f57073...69510d1. Read the comment docs.

@achew22
Copy link
Collaborator

achew22 commented Sep 9, 2019

@cemenson welcome to the party! 🎉 🎈 🎉

This is a great first PR on a project and great first contribution to the open source world. Thank you so much for taking the time to fix something that didn't look right. This is how open source gets better.

I look forward to your next PR, and if there is anything I can do to have it be one that enhances this project, just let me know.

Thanks again!

@cemenson
Copy link
Contributor Author

cemenson commented Sep 9, 2019

Thanks @achew22! Glad to help!

@cemenson cemenson closed this Sep 9, 2019
@cemenson
Copy link
Contributor Author

cemenson commented Sep 9, 2019

Sorry, such a noob. Am I supposed to close this PR?

@cemenson cemenson reopened this Sep 9, 2019
@achew22 achew22 merged commit 82dc083 into grpc-ecosystem:master Sep 9, 2019
@achew22
Copy link
Collaborator

achew22 commented Sep 9, 2019

No, but I appreciate your trying to help. On my side there is a "merge" button which I needed to hit. However, I wanted to make sure the tests passed before submitting. Sorry I forgot about this tab and just got back to it. It should be merged now in the master branch of the repo.

adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
* added additional info for custom http headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants