-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jaeger support for ctxtags extraction #147
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=========================================
+ Coverage 73.23% 73.33% +0.1%
=========================================
Files 36 36
Lines 1300 1305 +5
=========================================
+ Hits 952 957 +5
Misses 300 300
Partials 48 48
Continue to review full report at Codecov.
|
Would you mind adding a few tests around |
Yeah, sure! Give few minutes! |
Thank you 😀 |
tracing/opentracing/id_extract.go
Outdated
} else if key == "uber-trace-id" { | ||
parts := strings.Split(val, ":") | ||
if len(parts) == 1 { | ||
// for extraordinary cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extraordinary cases? Maybe special cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstance would this happen? (I'm not very familiar with Jaeger)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not encountered such cases, so I left this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the case, why don't you just error or log instead of letting it through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok if only normal case would be handled?
Did you manage to get a failing test first? I'm not convinced that there would be a failing test if we removed the code in |
thank you for your patience, I hope that I managed to find optimal solution for testing this functionality |
Thank you! |
No description provided.