Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing vet issues ... most relating to the Examples #132

Merged
merged 4 commits into from
Mar 1, 2018
Merged

fixing vet issues ... most relating to the Examples #132

merged 4 commits into from
Mar 1, 2018

Conversation

domgreen
Copy link
Contributor

No description provided.

@domgreen domgreen self-assigned this Feb 28, 2018
@domgreen domgreen requested review from yifanzz and mwitkow February 28, 2018 14:55
@codecov-io
Copy link

codecov-io commented Feb 28, 2018

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files          36       36           
  Lines        1292     1292           
=======================================
  Hits          952      952           
  Misses        293      293           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7cbcd2...5c44700. Read the comment docs.

@domgreen domgreen requested a review from devnev March 1, 2018 12:04
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

opts := []grpc_logrus.Option{
grpc_logrus.WithLevels(customFunc),
}
// Make sure that log statements internal to gRPC library are logged using the zapLogger as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean logrus logger here?

@domgreen domgreen merged commit eb23b08 into grpc-ecosystem:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants