ctxloggers for zap and logrus should live with logging #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 73.2% 73.68% +0.47%
==========================================
Files 36 36
Lines 1284 1292 +8
==========================================
+ Hits 940 952 +12
+ Misses 295 293 -2
+ Partials 49 47 -2
Continue to review full report at Codecov.
|
yifanzz
approved these changes
Feb 28, 2018
yifanzz
suggested changes
Feb 28, 2018
tags/zap/context.go
Outdated
| } | ||
|
|
||
| // TagsToFields transforms the Tags on the supplied context into zap fields. | ||
| func TagsToFields(ctx context.Context) []zapcore.Field { |
There was a problem hiding this comment.
Should maintain the public API here
tags/zap/context.go
Outdated
|
|
||
| // ToContext adds the zap.Logger to the context for extraction later. | ||
| // Returning the new context that has been created. | ||
| func ToContext(ctx context.Context, logger *zap.Logger) context.Context { |
yifanzz
approved these changes
Feb 28, 2018
tags/zap/context.go
Outdated
| } | ||
|
|
||
| // ToContext adds the zap.Logger to the context for extraction later. | ||
| // Returning the new context that has been created. | ||
| // Deprecated: use ctxzap.ToContext |
There was a problem hiding this comment.
Should keep the original docs line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would fit much better if the ctxloggers for both zap and logrus lived under the logging sub folder rather than with the tags ... although they add tags to logger on the context the primary use is for them to be used to add fields to the context.