Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiSelect for list conditions on enum attributes #3184

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Kevin-Chant
Copy link
Contributor

Features and Changes

Changes the ConditionInput logic to use a MultiSelectField when using a list operator on an enum field.

Testing

  • Checked that the UX works correctly (typeahead, enter to select, doesn't allow a value outside of the enum) in simple mode
  • If an invalid value is entered in advanced mode, handles it gracefully (allows it to exist but doesn't render in simple mode. If updated in simple, the invalid value is purged)

Screenshots

image

image

@Kevin-Chant Kevin-Chant merged commit fa1df7d into main Oct 29, 2024
2 of 3 checks passed
@Kevin-Chant Kevin-Chant deleted the kc/enum-multiselect-for-list-conditions branch October 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Improve the enum value checks in feature conditions
2 participants