Bugfix: Error for updating Visual Changeset URL patterns #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2296-bttf has been deployed. Preview environment endpoints are available at: |
bryce-fitzsimons
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2283
Bug was introduced on Mar 21 in https://github.com/growthbook/growthbook/pull/2062/files#diff-927559bb0a1c6030d6f19383870f6f89ca3d5537f91116531fb65f2e651ed46fR2303
This PR ensures that visual changes on a changeset are only overriden when provided with a non-empty list of visual changes. For the case we want to remove visual changes, there should be at minimum a visual change per variation that have all values (css, js, dom mutations) set as empty, which is existing behavior.