Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind_image_texture should take Option<Self::Texture> #259

Closed
ennis opened this issue Oct 10, 2023 · 1 comment · Fixed by #325
Closed

bind_image_texture should take Option<Self::Texture> #259

ennis opened this issue Oct 10, 2023 · 1 comment · Fixed by #325

Comments

@ennis
Copy link

ennis commented Oct 10, 2023

It's valid to call glBindImageTexture with texture equal to zero, in which case it will break any previous binding. The current signature takes Self::Texture. It should be Option<Self::Texture> to be consistent with other bind_ functions.
@grovesNL
Copy link
Owner

Sure, happy to accept a PR for this

sagudev added a commit to sagudev/glow that referenced this issue Nov 2, 2024
@sagudev
Make bind_image_texture take Option<Self::Texture>
4db959c 
Fix grovesNL#259

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev mentioned this issue Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make bind_image_texture take Option<Self::Texture> sagudev/glow
2 participants
@grovesNL @ennis