Fix a compilation error #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nunobaldaia. Hasn't it already been fixed by #92? |
|
Hi @groue. Yes, you are right, #92 fixed that issue. I haven't noticed that pull request. However, that line is not present on the current master branch: https://github.com/groue/GRMustache/blob/master/src/classes/Compiling/TemplateAST/GRMustacheTag.h Neither on v7.3.1. |
|
Oh, it looks like I messed up the last PR. |
groue
added a commit
that referenced
this pull request
Apr 22, 2015
Fix compile error "expected a type"
|
Thanks! :) |
|
I'll release 7.3.2 with the actual include of this change... Hold on a minute :-) |
|
v7.3.2 has shipped with your fix: https://github.com/groue/GRMustache/blob/master/src/classes/Compiling/TemplateAST/GRMustacheTag.h Thanks @nunobaldaia! |
|
Thanks Gwendal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a minor change that just fixes a compilation error.