Suppress useLayoutEffect warning #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for whimsical-moxie-6e43a0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you! This solution makes sense given it will be supported by React on its next release. Good notes re: performance downsides of the alternate approach. |
taysea
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the
useLayoutEffectwarning. This warning will be removed in the next version of React. For now this code is a temporary solution until the next version of react is released. See facebook/react#26395.I also attempted a different solution where instead of suppressing the warning I replaced
ReactDOMServer.renderToStringwith a method that usescreateRootandflushSync(solution can be found here: https://stackoverflow.com/questions/58181405/pass-a-react-component-to-leaflet-popup). This did fix the useLayoutEffect errors but I thought that the performance issues with flushSync were not worth it and we would be better off suppressing the warning.Closes #37