Added support for extensions, including usage and args check - use it to add math functions #96
Conversation
…ck, example with math.Pow()
| } | ||
| } | ||
|
|
||
| func pow(args []object.Object) object.Object { |
There was a problem hiding this comment.
Can't use a variadic or simply have 2 parameter, it might be a huge refactoring but it would be better I think
There was a problem hiding this comment.
what do you mean? MaxArgs -1 is variadic (and variadic is same as [] anyway)
There was a problem hiding this comment.
It could be pow(val, exp)
Or pow(args ...object.Object)
There was a problem hiding this comment.
yes... so that would be like it is today MinArgs=MaxArgs=2
the second one is MinArgs=0 MaxArgs=-1
There was a problem hiding this comment.
See 7d759b8 for sprintf integration as variadic example
|
In one commit you said "gofump, instead of gofumpt" |
…turned (still fatal, but returned)
…he function to name mapping
…ent PR for this but 1/2 of them are new to this PR and it came up here
…commands, so renamed accordingly
… the variadic any args to it
|
@ccoVeille I'm working on a grol side variadic support off this branch but... I think we should merge this first? |
example with math.Pow() exposed as pow(float1 float2) (and auto convert from integer)
Fixes #9, #41