implement func name(...) {....} as short for name=func(...) {...}
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handlElse -> printElsehandlElse -> printElse
handlElse -> printElsefunc name(...) {....} as short for name=func(...) {...}
ccoVeille
approved these changes
Aug 2, 2024
Comment on lines
+491
to
+493
| name := &ast.Identifier{} | ||
| name.Token = p.curToken | ||
| lit.Name = name |
There was a problem hiding this comment.
It's a bit difficult to read
Maybe this
Suggested change
| name := &ast.Identifier{} | |
| name.Token = p.curToken | |
| lit.Name = name | |
| lit.Name = &ast.Identifier{Token: p.curToken} |
There was a problem hiding this comment.
But the rest of the code might be aligned with current code.
There was a problem hiding this comment.
it's like that because the Tokens are in Base... so you'd need to do the super annoying {Base: Base{Token: ...
| } | ||
|
|
||
| // Common part of Inspect and SetCacheKey. Outputs the rest of the function. | ||
| func (f *Function) finishFuncOutput(out *strings.Builder) string { |
There was a problem hiding this comment.
A bit out of this PR, but maybe you could use godoc link
Suggested change
| func (f *Function) finishFuncOutput(out *strings.Builder) string { | |
| // Common part of [Inspect] and [SetCacheKey]. Prints the rest of the function. |
There was a problem hiding this comment.
I'm unsure about the godoc link in such case
There was a problem hiding this comment.
godoc doesn't generate doc for private function does it? or maybe there is an option to do so I suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func name(...as alternative toname = func(...#44handlElse->printElse/ corrects Allow else if #91