Handle block comments /* */ #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
commented
Jul 30, 2024
…, added make target showing env vars to setup logger in tests
ccoVeille
approved these changes
Aug 1, 2024
ldemailly
commented
Aug 1, 2024
| {"5 + 5 + 5 + 5 - 10 /* some block comment */", 10}, | ||
| /* These don't work, we need to make comment a identity operator or prune them entirely from the AST. */ | ||
| // {"5 + /* block comment in middle of expression */ 2", 7}, | ||
| // {" - /* inline of prefix */ 5", -5}, |
There was a problem hiding this comment.
@ccoVeille also this ^ ie the block/inline comments currently do break expressions, basically act as a ; or \n and making them not do that requires more surgery (like 2 passes, one for -format/pretty print and one for nuking the comments... which seems not ideal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difficulty is in the -format output to keep the block comment where they were (same line or new line etc)
This was harder to get right than... I wanted
fixes #14