Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping line comments on same line. #80

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Keeping line comments on same line. #80

merged 5 commits into from
Jul 29, 2024

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jul 29, 2024 •
edited
Loading

Fix #79

  • adding failing test first
  • trim trailing whitespaces
  • fix

@ldemailly ldemailly marked this pull request as draft July 29, 2024 20:18
@ldemailly ldemailly marked this pull request as ready for review July 29, 2024 21:09
@ldemailly ldemailly requested a review from ccoVeille July 29, 2024 21:26
@ldemailly
Copy link
Member Author

(review at your leisure post merge or most fyi)

@ldemailly ldemailly merged commit d4321a2 into main Jul 29, 2024
1 check passed
@ldemailly ldemailly deleted the comments_same_line branch July 29, 2024 21:38
ccoVeille
ccoVeille approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keep // comment on same line
2 participants
@ldemailly @ccoVeille