Expose errors (for bot). #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldemailly
commented
Jul 15, 2024
| @@ -84,7 +85,8 @@ func Interactive(in io.Reader, out io.Writer, options Options) { | |||
| } | |||
|
|
|||
| // Returns true in line mode if more should be fed to the parser. | |||
| func EvalOne(s, macroState *eval.State, what string, out io.Writer, options Options) bool { | |||
| // TODO: this one size fits 3 different calls (file, interactive, bot) is getting spaghetti. | |||
There was a problem hiding this comment.
@ccoVeille I realize ^
ccoVeille
reviewed
Jul 16, 2024
| @@ -72,7 +73,7 @@ func Interactive(in io.Reader, out io.Writer, options Options) { | |||
| return | |||
| } | |||
| l := prev + scanner.Text() | |||
| contNeeded := EvalOne(s, macroState, l, out, options) | |||
| contNeeded, _ := EvalOne(s, macroState, l, out, options) | |||
There was a problem hiding this comment.
Why ignoring errors here?
Maybe it's OK, but a comment would help
There was a problem hiding this comment.
it's because they've been printed interactively, which is kinda why the spagheti of ifs and modes in EvalOne isn't great, I probably should just copy paste exactly for 3 modes, or ... clean up somehow
agreed on comment, adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for grol-io/grol-discord-bot#7