int("")==0; adding trim(), trim_left() and trim_right(); new -no-register option to disable register optimizations
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int(): trim spaces in strings, and "" is 0; adding trim(), trim_left() and trim_right()
ccoVeille
reviewed
Dec 11, 2024
| @@ -324,6 +324,8 @@ func createJSONAndEvalFunctions(c *Config) { | |||
| } | |||
| } | |||
|
|
|||
| const DefaultTrimSet = " \r\n\t" | |||
There was a problem hiding this comment.
Suggested change
| const DefaultTrimSet = " \r\n\t" | |
| const defaultTrimSet = " \r\n\t" |
Unless you plan to reuse it
There was a problem hiding this comment.
I figured it would be good to get it documented (thus exposed)
int(): trim spaces in strings, and "" is 0; adding trim(), trim_left() and trim_right()int(): trim spaces in strings, and "" is 0; adding trim(), trim_left() and trim_right(); new -no-register option to disable register optimizations
ldemailly
commented
Dec 11, 2024
int(): trim spaces in strings, and "" is 0; adding trim(), trim_left() and trim_right(); new -no-register option to disable register optimizationsint("")==0; adding trim(), trim_left() and trim_right(); new -no-register option to disable register optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite auto memoization, advent day11 is still too slow - todo: follow up further