Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing issue inside if conditions #180

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Fix parsing issue inside if conditions #180

merged 2 commits into from
Aug 26, 2024

Conversation

ldemailly
Copy link
Member

Hardcoding effect of open paren wasn't very good

  • added test
  • fix

Fix #179

Of note we should rely simplify the expressions because

if 1+2==3 {} 

doesn't need to be written

if (1+2)==3 {}

@ldemailly ldemailly requested a review from ccoVeille August 26, 2024 02:31
@ldemailly ldemailly merged commit e551027 into main Aug 26, 2024
1 check passed
@ldemailly ldemailly deleted the bug_179 branch August 26, 2024 02:32
Copy link
Contributor

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsing bug with () comparison
2 participants