ALL_CAPS are now constants. Changed/shared recursive function environment. Fixed bug with macro environment. Added pprof. #102
Conversation
…h is oddly not triggering
…t; allow resetting to same exact value; tinygo workaround for tinygo-org/tinygo#4382
todo: might have messed up the rebase conflicts
| err := extensions.Init() | ||
| if err != nil { | ||
| log.Fatalf("Error initializing extensions: %v", err) | ||
| return log.FErrf("Error initializing extensions: %v", err) |
There was a problem hiding this comment.
So FErrf is Fatalf ?
The name could be better
There was a problem hiding this comment.
it's same level as fatal but doesn't try to exit, returns non 0 instead which lets defer run and also make linters happy (and works well with main() {os.Exit(Main())} which lets testscript work well too)
| err := extensions.Init() | ||
| if err != nil { | ||
| log.Fatalf("Error initializing extensions: %v", err) | ||
| return log.FErrf("Error initializing extensions: %v", err) |
There was a problem hiding this comment.
Why using your ferry here, and using Fatalf in previous if block you add
There was a problem hiding this comment.
ic you mean why not change all of them, so far I only changed what the linter complained about re defer not to running but probably should be all yes, in theory/for consistency
There was a problem hiding this comment.
of note there are still a few more log.Fatalf in other functions (like if you fail to pass a valid filename) and it's fine... for now at least (just means some pprof defer won't happen)
Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
| return val | ||
| } | ||
|
|
||
| // Doesn't unwrap return - return bubbles up. | ||
| func (s *State) evalInternal(node any) object.Object { | ||
| func (s *State) evalInternal(node any) object.Object { //nolint:funlen // quite a lot of cases. |
There was a problem hiding this comment.
Maybe you could add a map[type]func(Node) Object
Then you create one method per type
So evalInternal method will then simply check if there is a func, then call it
There was a problem hiding this comment.
What do you think about this?
There was a problem hiding this comment.
Thanks for the reminder, I had skipped that one earlier
If it worked, we'd need to profile it (good that there is -profile-cpu now) but I don't think it'd help because you'd need to cast anyway inside each small function (but try and let me know :) ?)
Note that for other types, like token.Type or object.Type an array lookup would be good, as the type fit into uint8 which eliminates bound checks, and I had started something like that in #93
| if i != 0 && v == '_' { | ||
| continue | ||
| } | ||
| if v < 'A' || v > 'Z' { |
There was a problem hiding this comment.
Constant may/could also contains number, no?
There was a problem hiding this comment.
well... not right now indeed :) PI2=PI; PI2++ works https://grol.io/?c=PI2=PI+PI2%2B%2BPI2
fixes #98
#47 (comment)
fixes #47
Also fixes mix up with macro environment which was incorrectly reusing the full eval.State when it really only needs object.Environment, split the two.
This showed up as a bug with ==> macro showing up in output even if no macro was defined (because it got PI and E from other MR)
Added
-profile-memand-profile-cpuoptionsFigured out regression and saved as examples/pi_perf.gr
Handle tabs in wasm share button