Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pVACvector bug that would result in not all junctional epitopes getting tested on clipping #1200

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

susannasiebert
Copy link
Contributor

@susannasiebert susannasiebert commented Feb 10, 2025

When clipping, we would remove amino acids at the beginning and/or end of a peptide sequence but we wouldn't include additional amino acids to make up for the clipped amino acids. This resulted in not all potential junctional epitopes getting tested.

Example:

>peptide1					
GYIRQVGDFHQVIIRGRGHILPYDQPLRAFDMI     
>peptide2                           
SCEVGMAYSMEKYRRTDNMARVMVRYMKYLRQK

peptide1 -> peptide 2 junction for a 9mer junctional epitopes:

PLRAFDMI|SCEVGMAY

buggy junction when clipping the end of peptide1 by 1 amino acid (without this fix):

PLRAFDM|SCEVGMAY

correct junction (with this fix):

QPLRAFDM|SCEVGMAY

@susannasiebert susannasiebert added this to the 5.1.1 milestone Feb 10, 2025
@susannasiebert susannasiebert changed the base branch from master to staging February 10, 2025 18:19
@susannasiebert susannasiebert changed the base branch from staging to hotfix February 10, 2025 18:19
@susannasiebert susannasiebert changed the base branch from hotfix to staging February 19, 2025 15:55
@susannasiebert susannasiebert merged commit 4eb4d0d into staging Feb 19, 2025
10 of 11 checks passed
@susannasiebert susannasiebert deleted the pvacvector_bug branch February 20, 2025 19:43
@susannasiebert susannasiebert modified the milestones: 5.1.1, 5.2.0 Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant