Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated column tooltips #1189

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Jan 31, 2025

I added a tooltip for Num Included Peptides and replaced the old Eval tooltip with one for Ref Match.

Resolves issue #1187

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of change suggestions. I think it's also a good idea to add tooltips for the Acpt, Rej, and Rev columns. Something to effect of "Click the thumps-up button to accept a neoantigen candidate". etc.

Also, please change the base branch of the PR to the hotfix branch.

@susannasiebert susannasiebert linked an issue Jan 31, 2025 that may be closed by this pull request
@ldhtnp ldhtnp changed the base branch from staging to hotfix January 31, 2025 19:03
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert changed the base branch from hotfix to staging February 19, 2025 15:53
@susannasiebert susannasiebert merged commit fda9e34 into griffithlab:staging Feb 19, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect pVACview header tooltips
2 participants