-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added argument for specifying NetMHCIIpan/NetMHCIIpanEL version #1181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good overall. I made a few comments for suggested changes.
Also, you'll want to add tests for your new command in the |
I think we are missing the standalone |
The Features documentation pages for the various tools (e.g., https://pvactools.readthedocs.io/en/latest/pvacseq/features.html) has a table that list the version of each tool that is supported. We should add the additional NetMHCIIpan/NetMHCIIpanEL versions, note the default, as well as the one version that is IEDB API-only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I added the argument
--netmhc_pan_version
to pvacseq, pvacbind, pvacfuse, pvacsplice, and pvacvector. The argument supports four versions: 4.0, 4.1, 4.2, and 4.3. I also added an argument that can be used to list the valid versionsvalid_netmhcpan_versions
. Alongside the additions I had to make to get the arguments implemented, I had to modify the code used to remove the sample name and grab the method name inoutput_parser.py
because the method name can now include a version number. Before this modification, the version number would be trimmed and dropped off of the method name resulting in issues downstream.This is for issue #457