Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added argument for specifying NetMHCIIpan/NetMHCIIpanEL version #1181

Merged
merged 9 commits into from
Feb 19, 2025

Conversation

ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Jan 22, 2025

I added the argument --netmhc_pan_version to pvacseq, pvacbind, pvacfuse, pvacsplice, and pvacvector. The argument supports four versions: 4.0, 4.1, 4.2, and 4.3. I also added an argument that can be used to list the valid versions valid_netmhcpan_versions. Alongside the additions I had to make to get the arguments implemented, I had to modify the code used to remove the sample name and grab the method name in output_parser.py because the method name can now include a version number. Before this modification, the version number would be trimmed and dropped off of the method name resulting in issues downstream.

This is for issue #457

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good overall. I made a few comments for suggested changes.

@susannasiebert
Copy link
Contributor

Also, you'll want to add tests for your new command in the test_pvacseq|bind|vector|splice.py files. Check out how the valid_alleles and valid_algorithms are tested in there and implement similar checks. That should probably get your coverage up as well and make the coveralls check pass.

@ldhtnp ldhtnp changed the base branch from master to staging January 29, 2025 21:59
@susannasiebert
Copy link
Contributor

I think we are missing the standalone valid_netmhciipan_versions command from the pVACfuse tree. You will also want to add documentation for the new commands in each of the docs/pvacseq|fuse|splice|bind|vector/additional_commands.rst files.

@susannasiebert
Copy link
Contributor

The Features documentation pages for the various tools (e.g., https://pvactools.readthedocs.io/en/latest/pvacseq/features.html) has a table that list the version of each tool that is supported. We should add the additional NetMHCIIpan/NetMHCIIpanEL versions, note the default, as well as the one version that is IEDB API-only.

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit 620b1df into griffithlab:staging Feb 19, 2025
0 of 5 checks passed
@susannasiebert susannasiebert linked an issue Feb 21, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple versions of prediction algorithms
2 participants