Fix issue causing "cannot set some dhcp options to null in network resource" #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can set some DHCP properties to null
itakouna
reviewed
Sep 25, 2023
| dhcpGateway := d.Get("dhcp_gateway").(string) | ||
|
|
||
| dhcpGateway, isSet := d.Get("dhcp_gateway").(string) | ||
| if isSet && dhcpGateway != "" { |
There was a problem hiding this comment.
As I user, I've to set the dhcp_gateway to None/null in the TF to unset the value. is that correct?
There was a problem hiding this comment.
Yes. Either you set to null or remove the field from the tf file.
itakouna
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
gsclient-gov3.14.0.UpdateNetworkwithPutUpdateNetwork, so some dhcp options can be set to null in network resource.