Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MS SQL server backup fields & add upfront validations for backup parameters #170

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Update MS SQL server backup fields & add upfront validations for backup parameters #170

merged 2 commits into from
Jun 22, 2021

Conversation

nvthongswansea
Copy link
Member

@nvthongswansea nvthongswansea commented Jun 21, 2021 •
edited
Loading

  • Add field backup_retention to MS SQL server backup.
  • Add upfront validations for MS SQL server backup's params.
  • Fix MS SQL server backup's params cannot be updated.
  • Update docs.

@nvthongswansea nvthongswansea requested a review from bkircher June 21, 2021 13:45
@bkircher bkircher self-assigned this Jun 22, 2021
bkircher
bkircher approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@bkircher bkircher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkircher bkircher merged commit ecb2457 into master Jun 22, 2021
@bkircher bkircher deleted the mssqlbackup branch June 22, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkircher bkircher bkircher approved these changes

Assignees

@bkircher bkircher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvthongswansea @bkircher