Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ordering of network in server resource always asks for update (mult. networks attached to one server) #142

Closed
nvthongswansea opened this issue Mar 18, 2021 · 7 comments
Closed

The ordering of network in server resource always asks for update (mult. networks attached to one server) #142

nvthongswansea opened this issue Mar 18, 2021 · 7 comments
Assignees
@nvthongswansea
Labels
breaking-change bug
Milestone
1.14.0

Comments

@nvthongswansea
Copy link
Member

nvthongswansea commented Mar 18, 2021 •
edited
Loading

Even though nothing is changed in a server resource, the ordering of the network always ask for update (when mult. networks attached to one server). This is not good, since updating network in a server resource requires the server to be off.
@nvthongswansea nvthongswansea self-assigned this Mar 18, 2021
@bkircher bkircher added this to the v1.8.5 milestone Mar 19, 2021
@nvthongswansea nvthongswansea mentioned this issue Mar 19, 2021
Merged
@bkircher
Copy link
Contributor

Re-open because this is a breaking change

@bkircher bkircher reopened this Mar 23, 2021
@bkircher bkircher modified the milestones: v1.8.5, v2.0.0 Mar 23, 2021
@bkircher
Copy link
Contributor

bkircher commented Mar 23, 2021 •
edited
Loading

If it is okay with you @nvthongswansea , I will move 3857fd8 to a separate branch (named v2 or so) and revert this commit in master?

@nvthongswansea
Copy link
Member Author

If it is okay with you @nvthongswansea , I will move 3857fd8 to a separate branch (named v2 or so) and revert this commit in master?

Give me a few hours, I might find something that can fix the back-compat.

@nvthongswansea
Copy link
Member Author

@bkircher could you rollback the master branch and move the 3857fd8 to a separate branch, please?

@nvthongswansea
Copy link
Member Author

Or you can remove that completely, since I found other way to deal with the network ordering issue.

bkircher added a commit that referenced this issue Mar 23, 2021
@bkircher
Revert last commit
aeb9c36 
This reverts commit 3857fd8 ("Fix
network ordering causing server resource update") as it introduces a
breaking change. See discussion in issue #142.
@bkircher
Copy link
Contributor

Reverted on master. We can create a new branch (v2) as target branch for changes that are backward incompatible and need a major version bump.

@nvthongswansea nvthongswansea mentioned this issue Jul 13, 2021
Closed
@nvthongswansea nvthongswansea mentioned this issue Jan 13, 2022
Merged
@nvthongswansea
Copy link
Member Author

Done in v1.14.0.

@nvthongswansea nvthongswansea modified the milestones: v2.0.0, 1.14.0 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvthongswansea nvthongswansea

Labels
breaking-change bug
Projects
None yet
Milestone
1.14.0
2 participants
@bkircher @nvthongswansea