Skip to content

Commit

Permalink
Remove unnecessary mutex and concurrent run from additionalfieldstabl…
Browse files Browse the repository at this point in the history
…emodel
  • Loading branch information
jamescowens committed Jun 24, 2022
1 parent 6247b20 commit f513f10
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 1 addition & 5 deletions src/qt/voting/additionalfieldstablemodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,10 @@ const AdditionalFieldEntry* AdditionalFieldsTableModel::rowItem(int row) const

void AdditionalFieldsTableModel::refresh()
{
if (!m_poll_item || !m_refresh_mutex.tryLock()) {
if (!m_poll_item) {
return;
}

QtConcurrent::run([this]() {
std::vector<AdditionalFieldEntry> additional_fields;

for (const auto& iter : m_poll_item->m_additional_field_entries) {
Expand All @@ -176,9 +175,6 @@ void AdditionalFieldsTableModel::refresh()

static_cast<AdditionalFieldsTableDataModel*>(m_data_model.get())
->reload(additional_fields);

m_refresh_mutex.unlock();
});
}

Qt::SortOrder AdditionalFieldsTableModel::sort(int column)
Expand Down
1 change: 0 additions & 1 deletion src/qt/voting/additionalfieldstablemodel.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public slots:
private:
const PollItem* m_poll_item;
std::unique_ptr<QAbstractTableModel> m_data_model;
QMutex m_refresh_mutex;
};

#endif // GRIDCOIN_QT_VOTING_ADDITIONALFIELDSTABLEMODEL_H

0 comments on commit f513f10

Please sign in to comment.