Update default run directory from /var/run to /run #146
Conversation
|
Hi, |
There was a problem hiding this comment.
A few more comments:
- at least packaging/package-output/hpn_isshd-gsi.7.5p1c.patch, also contains
/var/run. - Likewise for packaging/debian/gsi-openssh/debian/gsi-openssh-server.init and packaging/debian/gsi-openssh/debian/gsi-openssh-server.postinst although I'm not sure they're being used.
- shouldn't we at some point update myproxy/source/VERSION to get it back in sync?
- Finally 3 out of the 4 files in myproxy/oauth/source/conf/ have
/var/run: but they don't even end up in the GCT.
I think all these updates can be made later too, but it is probably better to do them (at least the first bullet) at the same time?
Let's keep out GSI-OpenSSH for now. As per #67 (comment) things will or could change for GSI-OpenSSH in the GCT anyhow.
I'll try to update that file accordingly and push my changes to @ellert's branch.
What do you mean with that @msalle, is there something missing in this question? |
|
Ok, |
oops, had a |
Filesystem Hierarchy Standard 3.0 says about /var/run: "This directory was once intended for system information data describing the system since it was booted. These functions have been moved to /run." Using /var/run in systemd unit files and tmpfiles.d config files results in warnings in the logs: Dec 23 12:42:25 localhost.localdomain systemd[1]: /usr/lib/systemd/system/myproxy-server.service:16: PIDFile= references a path below legacy directory /var/run/, updating /var/run/myproxy-server/myproxy.pid → /run/myproxy-server/myproxy.pid; please update the unit file accordingly. /usr/lib/tmpfiles.d/myproxy-server.conf:1: Line references path below legacy directory /var/run/, updating /var/run/myproxy-server → /run/myproxy-server; please update the tmpfiles.d/ drop-in file accordingly.
|
Since an other PR for myproxy was merged I had to bump the version number for that. That meant that this PR then had to be rebased to resolve the conflicts. I cherrypicked the update of the VERSION file directly to master. |
myproxy-oauth-epel5 can be removed anyhow I think. But myproxy-oauth-2.4-deb is used in here: https://github.com/gridcf/gct/blob/master/packaging/debian/myproxy-oauth/debian/rules and the remaining two are used in https://github.com/gridcf/gct/blob/master/packaging/fedora/myproxy-oauth.spec, though from the logic only myproxy-oauth-2.4 seems to be for newer Fedora/EPEL package sources (i.e. at least Fedora 18 and EPEL 7), so myproxy-oauth can be removed, too (plus update to the RPM spec file), I assume. But maybe let's do that in a separate PR, as "myproxy-oauth" is a separate package anyhow. |
|
Hi @fscheiner I agree it's better done in a separate PR. |
|
As far as I know, that myproxy-oauth Python code was only used inside Globus Connect installations, so I think there's no need to keep it for GCT. |
Filesystem Hierarchy Standard 3.0 says about /var/run:
"This directory was once intended for system information data
describing the system since it was booted. These functions have been
moved to /run."
Using /var/run in systemd unit files and tmpfiles.d config files
results in warnings in the logs:
Dec 23 12:42:25 localhost.localdomain systemd[1]: /usr/lib/systemd/system/myproxy-server.service:16: PIDFile= references a path below legacy directory /var/run/, updating /var/run/myproxy-server/myproxy.pid → /run/myproxy-server/myproxy.pid; please update the unit file accordingly.
/usr/lib/tmpfiles.d/myproxy-server.conf:1: Line references path below legacy directory /var/run/, updating /var/run/myproxy-server → /run/myproxy-server; please update the tmpfiles.d/ drop-in file accordingly.