Fedora test deps and cleanup #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msalle
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Hi,
looks fine to me. One question though: Shouldn't you also add perl-interpreter as BuildRequires?
That seems to be required from https://fedoraproject.org/wiki/Packaging:Perl but perhaps not when you have explicit other Perl requirements?
Originally all components using the doxygen filter used a copy of the filter installed by globus-common. Later the filter script was copied to the source directory of each component that uses it, and the copy in globux-common is no longer used (it is not used by globus-common itself).
bc2926e to
0021418
Compare
Add additional perl dependencies for tests
0021418 to
c7b0cdd
Compare
|
You are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora changed the structure of their perl RPM and made it more modular. Some perl modules that used to be installed together with the perl interpreter are now separate modules. If these are used by the tests they must now be listed as build requires.
This PR also removes some unused test files.