Adding RichardsonLinearSolver #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiManyer
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Thank you for the contribution!
As a general comment, I would say the code is riddled with allocations. All allocations need to be moved to the numerical_setup phase, and the solve! method has to be allocation-free. I would use in-place operations instead of so much copying around.
Also:
- You need tests, both in serial and distributed.
- You need to summarize changes in NEWS.md
- You need to add the solver to the documentation, under
src/LinearSolvers.md
JordiManyer
approved these changes
Dec 19, 2024
|
@shreyas02 I think that for some reason microsoft removed BLAS from it's CI nodes. It's fixed now, just pull from master and tests should pass. |
|
Hi @JordiManyer, the CI for Documentation is failing. Any reason why? I had left a line between the docstring |
|
Thank you for your contribution @shreyas02 ! |
|
Thanks a lot for the help @JordiManyer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding
RichardsonLinearSolveras discussed with @JordiManyer in #86. Tests are yet to be added for this solver.