Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstructured grid refinement #149

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Unstructured grid refinement #149

merged 16 commits into from
Jul 19, 2024

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Jul 5, 2024

This is the follow-up PR to #148 . Requires Gridap#adaptivity to be merged first.

Main feature:

We aim to add refinement of generic unstructured distributed models, in the case where refinement glues produced by local (serial) refinement are already consistent. Notably, this happens for uniform refinement (i.e same RefinementRule for every cell in the old mesh).

This PR does NOT intend to

  • create an algorithm to make inconsistent glues consistent.
  • implement redistribution of unstructured meshes.

Other minor features:

  • Added propagation of labels when refining and redistributing. This was missing from Cartesian uniform refinement #148.
  • As a spinoff of UnstructuredDiscreteModel refinement, we are now able to simplexify in parallel.

@JordiManyer JordiManyer added the enhancement New feature or request label Jul 5, 2024
@JordiManyer JordiManyer self-assigned this Jul 5, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a37ada1) to head (aaa971a).
Report is 4 commits behind head on master.

Files Patch % Lines
src/Adaptivity.jl 0.00% 74 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #149   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          10      10           
  Lines        2777    2855   +78     
======================================
- Misses       2777    2855   +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer marked this pull request as ready for review July 18, 2024 13:53
@JordiManyer JordiManyer merged commit 9e1e6e9 into master Jul 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant