Moment based reffes: refactoring and extension of Gridap.Polynomials #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p.jl into moment-based-reffes
another one exists in Polynomials.PCurlGradMonomialBases.jl, that could lead to bugs in further refactoning
renamed
- ChebyshevPolynomialBases -> ChebyshevBasis
- JacobiPolynomialBases -> LegendreBasis
for consistency with MonomialBasis
added TensorPolynomialBasis that generalises/refactors MonomialBasis,
ChebyshevBasis and LegendreBasis, and any nD polynomial basis built as
an anisotropic tensor product of 1D polynomial bases.
to be tested
enable edge case (first orders) optimizations via dispatch
- factorized Q[Curl]Grad bases as instences of CompWiseTensorPolyBasis, enabling using any polynomial family as underlying 1D basis - deprecated num_terms in favor of length of Q[Curl]Grad spaces - changed the value of get_order(::Q[Curl]GradBasis), it now returns the actual maximum order of the basis functions, for consistency. the order of the basis polynomial changed in the Q[Curl]Grad basis, cf. CompWiseTensorPolyBasis
- new type NonTensorRTPolyBasis, which is a QCurlGradMonomialBasis
general for any hierarchical basis <:Polynomial (including Monomial)
- removed perms from NonTensorRTPolyBasis (former QCurlGradMonomialBasis),
it served no purpose excep changing the order of the basis function.
This means that the order of the basis function did change
…tion
- factorised evaluate!(PolynomialBasis) using a new generic
_evaluate_nd! _gradient_nd! _hessian_nd! interface
- made NedelecPreBasisOnSimplex and ModalC0Basis subtype of
PolynomialBasis and factorised what was possible
- homogenized names and updated exported names - updated news.md - handled deprecated APIs - added some docstrings - updated tests with new APIs
…o moment-based-reffes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## moment-based-reffes #1072 +/- ##
=======================================================
+ Coverage 83.89% 85.62% +1.72%
=======================================================
Files 209 211 +2
Lines 25348 24336 -1012
=======================================================
- Hits 21266 20837 -429
+ Misses 4082 3499 -583 ☔ View full report in Codecov by Sentry. |
in place De Casteljau combine De Casteljau's for _derivatives_1d add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing coverage.
Todo: