-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Disable lintr #480
CI: Disable lintr #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to approve this.
Hi, I traced the lintr issue into xmlparsedata (and the recent changes to getParseData in R-3.6), and have pushed a change into xmlparsedata to fix this. If you'd like to use the dev version of lintr, you could try adding both |
Thanks a lot @russHyde ! |
* master: Fix a typo in the `@keywords` roxygen directive. (grf-labs#481) Ensuring DiceKriging does not break forest training (grf-labs#455) CI: Disable lintr (grf-labs#480) Platform-independent random numbers [using stdlib copy] (grf-labs#469) test_regression_forest.R: fix argument name (grf-labs#477) CI: Only warn on lint error (grf-labs#474)
@jtibshirani @halflearned lintr does not break CI on R 3.6 anymore and with the current setup it never raises errors. Want it back in? Thought it was convenient mostly for <- instead of = which is impossible to remember |
A bug in lintr hinders the CI tests on R 3.6. Disable lintr for now and revert this once r-lib/lintr#384 has been resolved by the lintr developers.
A bug in lintr hinders the CI tests on R 3.6. Disable lintr for now and revert this once r-lib/lintr#384 has been resolved by the lintr developers.