Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable lintr #480

Merged
merged 3 commits into from
Aug 14, 2019
Merged

CI: Disable lintr #480

merged 3 commits into from
Aug 14, 2019

Conversation

erikcs
Copy link
Member

@erikcs erikcs commented Aug 14, 2019

A bug in lintr hinders the CI tests on R 3.6. Disable lintr for now and revert this once r-lib/lintr#384 has been resolved by the lintr developers.

@erikcs erikcs requested a review from halflearned August 14, 2019 00:57
Copy link
Member

@halflearned halflearned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to approve this.

@erikcs erikcs merged commit e9c7e1f into grf-labs:master Aug 14, 2019
@erikcs erikcs deleted the nolint branch August 14, 2019 03:50
@russHyde
Copy link

Hi, I traced the lintr issue into xmlparsedata (and the recent changes to getParseData in R-3.6), and have pushed a change into xmlparsedata to fix this. If you'd like to use the dev version of lintr, you could try adding both jimhester/lintr and r-lib/xmlparsedata to the r_github_packages field of your travis.yml.

@erikcs
Copy link
Member Author

erikcs commented Aug 14, 2019

Thanks a lot @russHyde !

erikcs added a commit to erikcs/grf that referenced this pull request Aug 16, 2019
* master:
  Fix a typo in the `@keywords` roxygen directive. (grf-labs#481)
  Ensuring DiceKriging does not break forest training (grf-labs#455)
  CI: Disable lintr (grf-labs#480)
  Platform-independent random numbers [using stdlib copy] (grf-labs#469)
  test_regression_forest.R: fix argument name (grf-labs#477)
  CI: Only warn on lint error (grf-labs#474)
@erikcs
Copy link
Member Author

erikcs commented Aug 17, 2019

@jtibshirani @halflearned lintr does not break CI on R 3.6 anymore and with the current setup it never raises errors. Want it back in?

Thought it was convenient mostly for <- instead of = which is impossible to remember

davidahirshberg pushed a commit to davidahirshberg/grf that referenced this pull request Dec 6, 2019
A bug in lintr hinders the CI tests on R 3.6. Disable lintr for now and
revert this once r-lib/lintr#384 has been resolved by the lintr
developers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants